Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): Add release script for maintenance #2208

Merged
merged 1 commit into from
Jun 22, 2017

Conversation

bobylito
Copy link
Contributor

Fixes #2203

This adds a new script to release the maintenance version. It is based on the previous release.sh.

@algobot
Copy link
Contributor

algobot commented Jun 22, 2017

Deploy preview ready!

Built with commit c450215

https://deploy-preview-2208--algolia-instantsearch.netlify.com

```sh
npm run release
yarn run release-maintenance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The run can be left out

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but it works too ;)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late to the party: I never managed to run a scrip with yarn that will use "npm publish" at some point. I got credentials not being read for publishing to npm. I believe this is still an issue (and that's why previous command was npm run release).

To me that's one of yarn drawbacks that could make us switch back to npm (because if we need to use both yarn and npm, it's a struggle)

Copy link
Contributor

@iam4x iam4x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

@bobylito bobylito merged commit c87bc76 into maintenance Jun 22, 2017
@bobylito bobylito deleted the maintenance-release-script branch June 22, 2017 16:29
bobylito added a commit that referenced this pull request Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants